Upgrade geojson-vt to 3.0.0 #5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandthakker
approved these changes
Dec 6, 2017
|
I have a feeling that benchmarks are broken on my machine due to some obscure GPU/OS issue, but here are the results of the only benchmark that uses GeoJSON (two runs):
|
|
Update: just tried upgrading to macOS 10.12.2 Beta 6 and the issue seems gone! I have snappy GL maps again. Woohoo! Updated bench (notice 2x smaller times):
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes GeoJSON indices take 2x less memory and generate tiles 20%–100% faster.
The external interface in the new geojson-vt release is the same, so this upgrade shouldn't be breaking, but let's watch out for any edge cases.