Add mapboxgl.LngLatBounds.isEmpty() method
#5917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
daniellsl
pushed a commit
to daniellsl/mapbox
that referenced
this pull request
Mar 17, 2023
Add `isEmpty()` method for preventing null case of `toArray()` Refs: mapbox/mapbox-gl-js#5917 https://docs.mapbox.com/mapbox-gl-js/api/geography/#lnglatbounds#isempty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior: Calling toArray() on a null-type bbox throws an exception instead of returning an empty array ("undefined this._sw doesn't have a toArray() method"). To check if bounds are defined the user needs to inspect internal properties.
Proposed solution: This PR adds a handy
isEmpty()method to the public interface, for checking if bounds are defined (similar to the Google Maps LatLngBounds.isEmpty() that many are used to having).Launch Checklist