add Map#isZooming method #6128
Merged
add Map#isZooming method #6128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lbud
previously requested changes
Feb 9, 2018
src/ui/camera.js
Outdated
| @@ -855,7 +855,17 @@ class Camera extends Evented { | |||
| * @returns A Boolean indicating whether the camera is moving. | |||
| */ | |||
| isMoving(): boolean { | |||
| return this.moving; | |||
| return !!this.moving; | |||
There was a problem hiding this comment.
Since moving and zooming are both boolean members of the Camera class already, let's remove the double negation here and below and just return this.moving / this.zooming.
There was a problem hiding this comment.
yep, this.zooming wasn't initialized in the constructor, so it could be undefined but I've initialized it as false in a new commit and removed the !!
anandthakker
approved these changes
Feb 12, 2018
pathmapper
pushed a commit
to pathmapper/mapbox-gl-js
that referenced
this pull request
Feb 13, 2018
* add Map#isZooming method * initialize Camera#zooming
pathmapper
pushed a commit
to pathmapper/mapbox-gl-js
that referenced
this pull request
Feb 13, 2018
* add Map#isZooming method * initialize Camera#zooming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6119
Launch Checklist