Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one error in array expression error message #6269

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

anandthakker
Copy link
Contributor

h/t @drewbo

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@anandthakker anandthakker merged commit 86b6fe7 into master Mar 2, 2018
@anandthakker anandthakker deleted the array-index-message branch March 2, 2018 18:48
anandthakker pushed a commit to mapbox/mapbox-gl-native that referenced this pull request Mar 2, 2018
anandthakker added a commit to mapbox/mapbox-gl-native that referenced this pull request Mar 2, 2018
* Port fix for "at" expression off-by-1 error

Refs mapbox/mapbox-gl-js#6269

* Consistency

* Add ignores for symbol positiong differences in real-world tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants