Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle *-rotate for point-placed symbols. #6631

Merged
merged 2 commits into from
May 9, 2018
Merged

Handle *-rotate for point-placed symbols. #6631

merged 2 commits into from
May 9, 2018

Conversation

ChrisLoer
Copy link
Contributor

@ChrisLoer ChrisLoer commented May 7, 2018

Fixes issue #6075 -- or at least fixes what I think is the chief complaint remaining there: that the combination of *-offset and *-rotate doesn't work for point labels.

This PR does not fix:

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • post benchmark scores
  • manually test the debug page

/cc @anandthakker @ansis

Fixes issue #6075.
Does not fix collision detection for point symbols with *-rotation-alignment: map, or for line-placed symbols with *-offset set.
@ChrisLoer ChrisLoer force-pushed the offset-rotate branch 2 times, most recently from c133323 to 4570ba2 Compare May 8, 2018 18:09
@ChrisLoer
Copy link
Contributor Author

One of the render tests kept failing because the collision box would draw slightly differently on the CI machine (I think this is just built into the variation in gl.LINES implementations). The part that was failing was not actually the thing under test (it was just a reference to show where the origin of the offset was), so I just removed it.

An alternative solution would be to write the tests as query tests, but I prefer render tests because they're more visual/simpler to understand.

@anandthakker
Copy link
Contributor

Nice un-overcomplication of the problem 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants