Map constructor should fail if WebGL init fails. #6744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, it's possible for the constructor to complete successfully but the painter not be defined.
This is because setupPainter doesn't throw an exception, but instead emits an ErrorEvent. The problem is that in the constructor() call, no listeners have been set up yet, so the user wouldn't be able to listen to this error and respond appropriately.
Later on, resize events cause the map to error, because painter.resize doesn't exist.
I'm open to suggestions, like:
Keep me posted,
Thanks!
Error logs
Error seen on Sentry:
Cannot read property 'resize' of undefined
This is occurring in the constructor.