Cancel pending requests on map.remove() #6826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandthakker
approved these changes
Jun 18, 2018
There was a problem hiding this comment.
I started thinking about how we could avoid the possibility of regressing this by forgetting to save and handle some Cancelable, but the only thing I could think of was having some kind AsyncManager container type that all cancellable-producing methods require as an argument, which would be overkill
| @@ -0,0 +1,3 @@ | |||
| // @flow | |||
|
|
|||
| export type Cancelable = { cancel: () => void }; | |||
There was a problem hiding this comment.
Too bad there isn't something like Rust's must_use attribute
There was a problem hiding this comment.
Yeah. facebook/flow#2281 / facebook/flow#3914.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6756.
Launch Checklist