Adds warning to geolocate control when unsupported #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewharvey
reviewed
Jul 7, 2018
src/ui/control/geolocate_control.js
Outdated
| @@ -259,7 +259,10 @@ class GeolocateControl extends Evented { | |||
| } | |||
|
|
|||
| _setupUI(supported: boolean) { | |||
| if (supported === false) return; | |||
| if (supported === false) { | |||
| warnOnce('Geolocation not supported. The Mapbox geolocate control will not be rendered.'); | |||
There was a problem hiding this comment.
+1 for adding this warning, since the developer has asked for the GeolocateControl, we should at least warn when that hasn't happened.
Could we change the warning to Geolocation support is not available, the GeolocateControl will not be visible.?
There was a problem hiding this comment.
@andrewharvey Absolutely, will update that now. Edit: Done!
aendra-rininsland
referenced
this pull request
in aendra-rininsland/mapbox-gl-js
Jul 9, 2018
aendra-rininsland
force-pushed
the
patch-1
branch
from
87b1527
to
8ab25f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changesThis is a really basic pull request that adds a simple warning to the geolocate control when it's added to a map in a context that is unsupported.
Mainly submitting this because I couldn't figure out for the life of me why the control wasn't displaying, turns out I was serving the page over HTTP. Adding a warning informs the developer that this is indeed the expected behaviour.