Include bindVertexBuffer
in Context.setDirty()
#7080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing a PoC of integrating CARTO VL with Mapbox GL using this new API we found a flickering issue (the screen was cleared to white intermittently sometimes).
The problem only happened when using WebGL outside the rendering loop (async).
We discovered that
BindVertexBuffer.set()
was being called after our async code executed and that theif (this.current !== v || this.dirty === true) {
didn't pass in the first timeset
was called after our code, which made our buffers bound and MGL buffers unbound, causing the problems.Adding
this.bindVertexBuffer.dirty = true;
toContext.setDirty()
seems to fix the issue.Thank you!