Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'mouseover' as synonym for 'mouseenter' #7299

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

  • briefly describe the changes in this PR
    • removes duplicative mouseover event that says its a synonym for mouseenter
  • manually test the debug page

Closes #7295

This looks like an oversight to me. The synonym was added in August 2017 8a68233 while the actual mouseover event was added in January 2018 35138df I'm guessing the synonym should have been removed at that time.

@ChrisLoer
Copy link
Contributor

Although it shouldn't make any difference, we should probably clean up the duplicate entry here too, right?

type: 'mousedown'
| 'mouseup'
| 'click'
| 'dblclick'
| 'mousemove'
| 'mouseover'
| 'mouseenter'
| 'mouseleave'
| 'mouseover'
| 'mouseout'
| 'contextmenu';

Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for cleaning this up!

@ryanhamley
Copy link
Contributor Author

Oh wait...should this go to mb-pages rather than master?

@ryanhamley ryanhamley changed the base branch from master to mb-pages September 19, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants