send correct timestamp with turnstile event #7381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asheemmamoowala
approved these changes
Oct 9, 2018
mollymerp
force-pushed
the
timestamp-fix
branch
2 times, most recently
from
98d1caa
to
db0e77e
Compare
mollymerp
force-pushed
the
timestamp-fix
branch
from
db0e77e
to
3676d61
Compare
kkaefer
pushed a commit
that referenced
this pull request
Oct 10, 2018
* send correct timestamp with turnstile event * update TurnstileEvent tests
5 tasks
kkaefer
pushed a commit
that referenced
this pull request
Oct 10, 2018
* send correct timestamp with turnstile event * update TurnstileEvent tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while implementing #7297 that our turnstile event is setting the
createdpayload property to a value frombrowser.now()which on most browsers is an alias forperformance.now()which is not the current day/time, but milliseconds since the JS started executing or something along those lines, so our values were always in the 1970s which I don't think is the intended behavior.Launch Checklist