Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of workers that can be spawned #7430

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
    • Do we need tests for this? And how would we test it?

@ryanhamley
Copy link
Contributor Author

ryanhamley commented Oct 16, 2018

What's our consensus on the max number of workers that should be spun up? @mollymerp suggested 6 and @mourner suggested 4. I assume the fewer is better as long as there isn't a limit below which we aren't spinning up enough workers. After gathering some customer feedback, I think 6 is probably an appropriate max number.

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 sounds good to me too.

@ryanhamley ryanhamley merged commit 58a61d6 into master Oct 18, 2018
@ryanhamley ryanhamley deleted the limit-worker-number branch October 18, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants