Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yarn.lock #7519

Merged
merged 3 commits into from
Oct 31, 2018
Merged

Update yarn.lock #7519

merged 3 commits into from
Oct 31, 2018

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

JSDOM was pinned to 11.11 but I updated package.json to allow it to be updated to 11.12. Forgot to include this in #7516 😬

mourner
mourner requested changes Oct 31, 2018
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your Yarn to the latest version so that we don't remove and add back the integrity field repeatedly in Yarn.lock update PRs.

@ryanhamley ryanhamley mentioned this pull request Oct 31, 2018
Closed
@ryanhamley ryanhamley merged commit e50fa34 into master Oct 31, 2018
@ryanhamley ryanhamley deleted the update-yarn-lock branch October 31, 2018 22:21
ryanhamley added a commit that referenced this pull request Oct 31, 2018
@ryanhamley
Update yarn.lock (#7519)
5b7768e
ChrisLoer pushed a commit that referenced this pull request Nov 1, 2018
@ryanhamley @ChrisLoer
Update yarn.lock (#7519)
ddc8eaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

@asheemmamoowala asheemmamoowala Awaiting requested review from asheemmamoowala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanhamley @mourner