Fix Query point translation for multi-point geometry #7581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asheemmamoowala
requested review from
mourner and
ansis
and removed request for
mourner
mourner
requested changes
Nov 10, 2018
asheemmamoowala
force-pushed
the
fix-6833
branch
from
b79e780
to
050f6f4
Compare
ryanhamley
approved these changes
Jan 23, 2019
mourner
approved these changes
Jan 23, 2019
asheemmamoowala
force-pushed
the
fix-6833
branch
from
050f6f4
to
bcaca5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6833
This wasn't an issue with
circle-translatebut with how query geometry is translated when it contains more than a single point.The
Point#_multmethod modifies the point, which causes the query geometry to be multiplied bypixelsToTileUnitsmultiple times here:mapbox-gl-js/src/style/query_utils.js
Line 44 in c708474