Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix images not being aborted when dequeued #7655

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Fix images not being aborted when dequeued #7655

merged 2 commits into from
Dec 14, 2018

Conversation

mourner
Copy link
Member

@mourner mourner commented Nov 30, 2018 •
edited
Loading

Theoretically fixes #7650. cc @ansis

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/studio and/or @mapbox/maps-design if this PR includes style spec changes

@mourner mourner requested a review from ansis November 30, 2018 17:46
@mourner mourner mentioned this pull request Nov 30, 2018
Closed
@ansis
Copy link
Contributor

ansis commented Dec 3, 2018

Looks good. Do you think it would be possible to add a unit test for this?

ansis
ansis approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@ansis ansis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've added a unit test to cover this bug.

@mourner mourner merged commit fd2ecf6 into master Dec 14, 2018
@mourner mourner deleted the fix-dequeue-abort branch December 14, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansis ansis ansis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

image requests that used to be queued can't be aborted
2 participants
@mourner @ansis