Fix removeFeatureState bug #8087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the feature object. This allows updating the buffers for features whose state has been removed, but also requires keep track of previously removed features.
peterqliu
approved these changes
Mar 27, 2019
|
Does this need porting to Native? |
|
No, because there is no native implementation of feature state as yet.
…On Fri, May 3, 2019, 01:44 Konstantin Käfer ***@***.***> wrote:
Does this need porting to Native?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#8087 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACYU2WY5MV3AYIJO5LB2CQ3PTP3OHANCNFSM4HBT3OGQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8026.
Feature state is applied only to those features identified by an
idthat have state set. TheremoveFeatureStatemethod, when called to clear state on all features in a source/source-layer, didn't clear the state of each feature, it cleared all the state for that source. i.e.{ idA: {..}, idB:{...} }became{}instead of{ idA: {}, idB: {}}.This PR fixes this by preserving the feature id that have had state applied previously, and clearing out that state. This allows the empty state to be applied to tiles that are being 'refreshed' when restored from the cache.
Benchmark results
Launch Checklist
cc @peterqliu @kbauhaus