-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resource loading edge cases #8612
Conversation
Things to test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the new debug/iframe-blob.html page work in all browsers?
Verified on OSX Safari/Chrome/Firefox, Android Chrome/Firefox, and Windows Edge.
Did not seem to work on IE11 😢
Does the debug/index.html page work when loaded via a file:// URL?
✅
… loaded via file:// URLs
…cument was loaded from a file:// URL
IE doesn't support HTML documents loaded from data or blob URLs. |
Changelog entry:
|
This PR bundles a few fixes for edge cases in resource loading:
file://
URL scheme as well (as long as they don't depend on other local resources)