Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Firefox SecurityError when opening window cache #8780

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Handle Firefox SecurityError when opening window cache #8780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
199f97b
Catch & warn on SecurityError when opening window cache
Sep 20, 2019
c6d48c0
Fix lint
Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/util/tile_request_cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// @flow

import {parseCacheControl} from './util';
import {warnOnce, parseCacheControl} from './util';
import window from './window';

import type Dispatcher from './dispatcher';
Expand Down Expand Up @@ -60,7 +60,9 @@ export function cachePut(request: Request, response: Response, requestTime: numb
prepareBody(response, body => {
const clonedResponse = new window.Response(body, options);

window.caches.open(CACHE_NAME).then(cache => cache.put(stripQueryParameters(request.url), clonedResponse));
window.caches.open(CACHE_NAME)
.catch(e => warnOnce(e.message))
.then(cache => cache.put(stripQueryParameters(request.url), clonedResponse));
});
}

Expand Down