Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tile mask geometry buffers are cleared when tile is unloaded #8850

Merged
merged 5 commits into from
Oct 10, 2019

Conversation

arindam1993
Copy link
Contributor

@arindam1993 arindam1993 commented Oct 9, 2019

Clear tile mask buffers when tiles are unloaded.
Cherrypick of the fix for the memory leak from #8814 .

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/studio and/or @mapbox/maps-design if this PR includes style spec or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port

@arindam1993 arindam1993 added this to the release-sangria milestone Oct 9, 2019
@arindam1993 arindam1993 self-assigned this Oct 9, 2019
[Co-author]: Konstantin Käfer <mail@kkaefer.com>
@asheemmamoowala
Copy link
Contributor

@arindam1993 What's the best way to verify these changes?

@arindam1993
Copy link
Contributor Author

@arindam1993 What's the best way to verify these changes?

I used the instrumented gl calls similar to #8814, and did a manual check on if the object count so see if it flattened out. But did not include that in this PR. Should I move the modified test page over as well?

I think an extension to the gl-stats page with a longer running test that plots growth over time would be a more formal way to check for things like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants