Upgrade pbf to v3.2.1 to fix memory leak with long strings in VT #8863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a memory leak when loading large vector tiles with long strings
|
Excellent! Any chance you might cut another release soon with this included as this didn’t seem to make it in before v1.4.1 released yesterday. Thanks! |
arindam1993
pushed a commit
that referenced
this pull request
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8471. Fixes a huge memory leak with large vector tiles that contain long strings in feature properties. The actual change is in mapbox/pbf#109.
Without this PR, when you zoom and hover over features in this JSBin test case, memory quickly grows to gigabytes for each thread in both Chrome and Firefox. After the patch, memory stays neatly below 20MB per thread.