Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the worker images once an image is added or removed + Render tests #9911

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

karimnaaji
Copy link
Contributor

Continuing PR #9838 with added render tests and extra manual testing done locally. Render test confirmed to fail on main branch. cc @francois2metz

Launch Checklist

  • briefly describe the changes in this PR
  • [n/a] include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • [n/a] document any changes to public APIs
  • [n/a] post benchmark scores
  • manually test the debug page
  • [n/a] tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Update the worker images once an image is added or removed to prevent unused image fallback. h/t @francois2metz</changelog>

Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I confirmed that it doesn't cause unnecessary tile loads.

@karimnaaji karimnaaji merged commit a85e997 into main Aug 3, 2020
@karimnaaji karimnaaji deleted the karim/francois2metz/update-images-after-add branch August 3, 2020 18:26
@karimnaaji karimnaaji self-assigned this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants