Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Full screen symbol flicker on pitched map with text-translate #11487

Closed
ChrisLoer opened this issue Mar 20, 2018 · 3 comments
Closed

Full screen symbol flicker on pitched map with text-translate #11487

ChrisLoer opened this issue Mar 20, 2018 · 3 comments
Labels
bug Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS rendering

Comments

@ChrisLoer
Copy link
Contributor

gl-native version of mapbox/mapbox-gl-js#6363.

To fix, we just need to pull over the updated shaders from mapbox/mapbox-gl-js#6365.

This problem existed in release-agua, although I don't know that it's serious enough to require a patch. We should definitely try to get the fix into release-boba.

/cc @ansis @malwoodsantoro @fabian-guerra @friedbunny
ChrisLoer added a commit that referenced this issue Mar 20, 2018
@ChrisLoer
[core] Avoid flashing on pitched overzoomed tiles.
0a15448 
Clamps perspective ratios in shaders.
Fixes issue #11487.
Port of GL JS PR #6365.
@ChrisLoer ChrisLoer mentioned this issue Mar 20, 2018
Merged
@fabian-guerra
Copy link
Contributor

@ChrisLoer is this something that the @mapbox/maps-android should be aware?

@fabian-guerra fabian-guerra added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS Core The cross-platform C++ core, aka mbgl labels Mar 20, 2018
@ChrisLoer
Copy link
Contributor Author

Yeah, I tagged @tobrun on the fix PR.

ChrisLoer added a commit that referenced this issue Mar 21, 2018
@ChrisLoer
[core] Avoid flashing on pitched overzoomed tiles.
4dc191b 
Clamps perspective ratios in shaders.
Fixes issue #11487.
Port of GL JS PR #6365.
@ChrisLoer
Copy link
Contributor Author

Fixed in #11488.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS rendering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ChrisLoer @friedbunny @fabian-guerra