Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Enabling .lineMetrics on an MGLShapeSource crashes Mapbox #13378

Closed
stoeffn opened this issue Nov 15, 2018 · 1 comment
Closed

Enabling .lineMetrics on an MGLShapeSource crashes Mapbox #13378

stoeffn opened this issue Nov 15, 2018 · 1 comment
Labels
Core The cross-platform C++ core, aka mbgl crash

Comments

@stoeffn
Copy link

stoeffn commented Nov 15, 2018

Hi,

I'm trying to use the new line gradient feature but, unfortunately, enabling .lineMetrics as per the documentation crashes Mapbox:

libc++abi.dylib: terminating with uncaught exception of type std::overflow_error: __next_prime overflow

For your convenience, I've attached a sample project.

Configuration

Mapbox SDK versions: 4.6
iOS versions: 12.1
Device/simulator models: iPhone 6 Plus
Xcode version: 10.1
@kkaefer kkaefer added crash Core The cross-platform C++ core, aka mbgl labels Nov 15, 2018
@fabian-guerra fabian-guerra added this to the release-iowaska milestone Nov 15, 2018
@zugaldia zugaldia removed this from the release-iowaska milestone Nov 27, 2018
@frederoni frederoni mentioned this issue Dec 5, 2018
Merged
@alexshalamov alexshalamov mentioned this issue Dec 11, 2018
Merged
alexshalamov added a commit that referenced this issue Dec 13, 2018
@alexshalamov
[ios, darwin] Make MGLFeature.attributes non-nullable and add integra…
b232873 
…tion test

Enforce non-nullable semantics for MGLFeature.attributes, to avoid construction of invalid mbgl::Feature properties
from nil NSDictionary object and align with public SDK property definition.

Integration test "testShapeSourceWithLineDistanceMetrics" is added to verify that MGLFeature is correctly converted.

Fixes issue #13378
alexshalamov added a commit that referenced this issue Dec 13, 2018
@alexshalamov
[ios, darwin] Make MGLFeature.attributes non-nullable and add integra…
b6b1067 
…tion test

Enforce non-nullable semantics for MGLFeature.attributes, to avoid construction of invalid mbgl::Feature properties
from nil NSDictionary object and align with public SDK property definition.

Integration test "testShapeSourceWithLineDistanceMetrics" is added to verify that MGLFeature is correctly converted.

Fixes issue #13378
julianrex pushed a commit that referenced this issue Dec 18, 2018
@alexshalamov
[ios, darwin] Make MGLFeature.attributes non-nullable and add integra…
9518472 
…tion test

Enforce non-nullable semantics for MGLFeature.attributes, to avoid construction of invalid mbgl::Feature properties
from nil NSDictionary object and align with public SDK property definition.

Integration test "testShapeSourceWithLineDistanceMetrics" is added to verify that MGLFeature is correctly converted.

Fixes issue #13378
@1ec5
Copy link
Contributor

1ec5 commented Mar 28, 2019

Fixed in #13543.

@1ec5 1ec5 closed this as completed Mar 28, 2019
@1ec5 1ec5 mentioned this issue Mar 28, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Core The cross-platform C++ core, aka mbgl crash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zugaldia @kkaefer @1ec5 @fabian-guerra @stoeffn