Run Xcode static analyzer on CircleCI for iOS builds

[1ec5]

#1538 would’ve been caught like crazy by Xcode’s static analyzer. We should run the static analyzer on Travis since we apparently aren’t great about running it manually ourselves (#1425). From what I’ve seen, the analyzer doesn’t take all that long on our entire project. Note that we’ll need to whitelist some warnings in upstream libraries, which are tracked in memononen/libtess2#19 and angusj/polyclipping#134.

/cc @incanus

[incanus]

@1ec5 What's the state of this?

[1ec5]

@incanus Further discussion in #1562. I believe the next step is to split the analysis into a separate target that can run in parallel with the others. But it still takes some 225 seconds for make analyze, which is just too high a penalty.

At this point, I’d be fine with a cron job on one of our local machines that analyzes the project every time we scrum.

[1ec5]

Added an Xcode Analyze step to the nightly Bitrise workflow.

[1ec5]

The Analyze step only works with schemes, not individual targets as gyp sets up. We’ll need to fix up the workflow after #4641 lands. In the meantime, I’ve removed the Analyze step to fix nightly builds.

[1ec5]

Since #1549 (comment), #4641 did land, making it possible to analyze a checked-in scheme. We also moved the iOS builds from Bitrise to CircleCI in #10257.

[friedbunny]

Done in release-boba via #11529.