Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Stop using obsolete? Map functions on Android #1575

Closed
ljbade opened this issue May 17, 2015 · 3 comments
Closed

Stop using obsolete? Map functions on Android #1575

ljbade opened this issue May 17, 2015 · 3 comments
Labels
Android Mapbox Maps SDK for Android GL JS parity For feature parity with Mapbox GL JS

Comments

@ljbade
Copy link
Contributor

ljbade commented May 17, 2015

These functions been replaced by custom implementation in iOS:

  • setZoom
  • setLatLng
  • resetNorth

(will add other as I find them)

Discussion on what to do in C++ side with these functions in #1574

@ljbade ljbade added the Android Mapbox Maps SDK for Android label May 17, 2015
@ljbade ljbade added this to the Android Beta milestone May 17, 2015
@ljbade ljbade added the GL JS parity For feature parity with Mapbox GL JS label May 17, 2015
@jfirebaugh
Copy link
Contributor

@ljbade What do you mean by "replaced by custom implementation"?

These functions are by no means obsolete. As with #1576, if iOS is no longer using them it may just be a question of which is more convenient.

@ljbade
Copy link
Contributor Author

ljbade commented May 18, 2015

@jfirebaugh Basically iOS used to use setZoom to change the zoom level, but now uses setLatLngZoom along with getLatLng.

I am wondering since setZoom etc have not been used for a while in iOS (even in the test cases) that they have been broken but nobody noticed.

@jfirebaugh
Copy link
Contributor

Closing here since I think this is causing confusion. Just because iOS doesn't use a particular method doesn't necessarily mean it's "obsolete" or "duplicate". Eventually we'll probably go through and rationalize the map view methods in the style of mapbox/mapbox-gl-js#1215, but that's not actionable right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

No branches or pull requests

2 participants