Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Use setScale instead of scaleBy #1576

Closed
ljbade opened this issue May 17, 2015 · 2 comments
Closed

Use setScale instead of scaleBy #1576

ljbade opened this issue May 17, 2015 · 2 comments
Labels
Android Mapbox Maps SDK for Android GL JS parity For feature parity with Mapbox GL JS
Milestone
android-v0.1.0

Comments

@ljbade
Copy link
Contributor

ljbade commented May 17, 2015

iOS has switched from scaleBy to setScale with pinch zooming gesture.

Should match on Android?
@ljbade ljbade added GL JS parity For feature parity with Mapbox GL JS Android Mapbox Maps SDK for Android labels May 17, 2015
@ljbade ljbade added this to the Android Beta milestone May 17, 2015
@1ec5
Copy link
Contributor

1ec5 commented May 17, 2015

scaleBy() was working fine, but it was more convenient to use setScale() for #1292. Our pinch callback is called continuously during the pinch, but UIPinchGestureRecognizer’s scale property is absolute rather than being incremental.

@jfirebaugh
Copy link
Contributor

Yeah, they don't necessarily have to match. Use whichever is more convenient.

@jfirebaugh jfirebaugh mentioned this issue May 18, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Milestone
android-v0.1.0
Development

No branches or pull requests
3 participants
@jfirebaugh @ljbade @1ec5