Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

remove requirement to use_frameworks! in iOS pod install #5633

Closed
andrewljohnson opened this issue Jul 10, 2016 · 5 comments
Closed

remove requirement to use_frameworks! in iOS pod install #5633

andrewljohnson opened this issue Jul 10, 2016 · 5 comments
Labels
build iOS Mapbox Maps SDK for iOS

Comments

@andrewljohnson
Copy link

andrewljohnson commented Jul 10, 2016

I followed the iOS SDK instructions to embed a Mapbox map into my app: https://www.mapbox.com/ios-sdk/#cocoapods

My pod install fails, because use_frameworks! doesn't play nicely with some other pods. I tried using cocoapods v1.0.1 and v0.38.2.

The 'Pods-MY APP' target has transitive dependencies that include static binaries:     
(/Pods/Crashlytics/iOS/Crashlytics.framework, /Pods/GoogleAnalytics/Libraries/libGoogleAnalytics.a, and /Pods/GoogleIDFASupport/Libraries/libAdIdAccessLibrary.a)

My guess is this is related to use using segment analytics, in conjunction with Mapbox for iOS.

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS build labels Jul 10, 2016
@1ec5
Copy link
Contributor

1ec5 commented Jul 10, 2016

Thanks, good catch! use_frameworks! probably became unnecessary as a result of #3183, when we started pointing our podspec to a dynamic framework instead of the old static library. We’re going to track this issue in our website’s internal repository. This issue will automatically close once it’s fixed.

@1ec5
Copy link
Contributor

1ec5 commented Jul 10, 2016

In the past, use_frameworks! was also necessary because we distribute a fat binary that includes both device and simulator content, and simulator content is disallowed when archiving for submission to the App Store. But it looks like these days CocoaPods is stripping unneeded architectures from dynamic frameworks even in the absence of use_frameworks!:

Stripped ~/Library/Developer/Xcode/DerivedData/Static-gdruxacujlenwqbtbkfrtxdmmdef/Build/Products/Debug-iphoneos/Static.app/Frameworks/Mapbox.framework/Mapbox of architectures: i386 x86_64

@andrewljohnson
Copy link
Author

Oh cool, is this working now? I couldn't follow that PR link.

I worked around in the app by installing the framework without cocoapods
for now.

On Fri, Jul 15, 2016 at 1:31 PM, Jason Wray notifications@github.com
wrote:

Closed #5633 #5633 via
mapbox/ios-sdk#167 https://github.com/mapbox/ios-sdk/pull/167.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#5633 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbzfxGjF-z3DuCxlF2ugmzZbUq2Bt2Gks5qV-44gaJpZM4JI3dt
.

@friedbunny
Copy link
Contributor

@andrewljohnson You should be able to use our pod (Mapbox-iOS-SDK) in your Podfile without having to specify uses_frameworks! — the only change that we made was to remove that unnecessary flag from the documentation. 😉

@andrewljohnson
Copy link
Author

OK thanks! I must have been conflating that with another incompatibility in
our Podfile. I'll open a separate issue if I figure it out.

On Fri, Jul 15, 2016 at 1:47 PM, Jason Wray notifications@github.com
wrote:

@andrewljohnson https://github.com/andrewljohnson You should be able to
use our pod (Mapbox-iOS-SDK) in your Podfile without having to specify
uses_frameworks! — the only change that we made was to remove that
unnecessary flag from the documentation. 😉


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5633 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbzf0dQ0H5mwfcQigPCpE7fax6rEfzFks5qV_H0gaJpZM4JI3dt
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

3 participants