Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MGLStyleAttributeFunction.functionType should be MGLStyleAttributeFunctionType #5969

Closed
1ec5 opened this issue Aug 12, 2016 · 3 comments · Fixed by #5980
Closed

MGLStyleAttributeFunction.functionType should be MGLStyleAttributeFunctionType #5969

1ec5 opened this issue Aug 12, 2016 · 3 comments · Fixed by #5980
Assignees
Labels
bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 12, 2016

MGLStyleAttributeFunction.functionType should be of type MGLStyleAttributeFunctionType, not NSNumber. The style specification allows the type property to be omitted, but the value is actually exponential (MGLStyleAttributeFunctionTypeExponential) or interval (MGLStyleAttributeFunctionTypeInterval) by default, depending on the property, and it’s meaningless for a function to have no type. So there’s no need for a nullable object here.

/cc @frederoni

@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Aug 12, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 12, 2016
@frederoni
Copy link
Contributor

type is omitted or not yet implemented in function.hpp so I suggest we remove MGLStyleAttributeFunction.functionType and the other unused types until we can make use of them.

@1ec5
Copy link
Contributor Author

1ec5 commented Aug 12, 2016

Is there a ticket tracking that core work? Seems like it'd be important for style specification compliance and GL JS parity.

@1ec5
Copy link
Contributor Author

1ec5 commented Aug 12, 2016

Per @lucaswoj, function types are only relevant for property functions, so we’ll only need SDK support for them once #4860 is implemented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants