This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Static analyzer warnings, mostly in runtime styling classes #7668
Labels
Comments
1ec5
added
build
iOS
|
I suspect this /cc @kkaefer |
This was referenced Jan 11, 2017
|
Took care of some of the miscellaneous warnings in #7670. |
|
Moving to v3.5.0. We think we understand the cause of these warnings. The runtime styling warnings may end up being correct behavior, but they’re numerous and verbose, so we need to figure out a way to either resolve or silence them to avoid missing legitimate issues. |
|
More static analyzer warnings in mbgl-core in Xcode 8.3.3 as of 19e872b, caused by |
|
34 more warnings in Darwin code in 19e872b caused by 34 more warningsIt’s becoming time-consuming to find actionable warnings that aren’t caused by |
|
Just a minor update: Running analyze on the |
|
This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
|
Update as of b4d5890 (with Xcode 10.2): Still lots of analyzer warnings, again mostly to do with and @tmpsantos any chance someone from GL can help look into this? I'm assuming these are false positives - but it would be good to put in the appropriate work-arounds to avoid these polluting the log and hiding real issues. (All this has been said by @1ec5 before, so it's nothing new!) |
|
Turns out the vast majority of these can be silenced by adding default initialization for @tmpsantos what's the process for updating |
|
/cc @artemp |
|
Re #7668 (comment) - for comparison (this is on a branch with some iOS analysis fixes) Beforehttps://github.com/mapbox/mapbox-gl-native/tree/jrex/analyzer-fixes @ d82b0b7: 367 warnings
Afterhttps://github.com/mapbox/mapbox-gl-native/tree/jrex/analyzer-fixes-experimental-variant @ 594b2de: 40 warnings
/cc @artemp ☝️ |
This was referenced Apr 25, 2019
Merged
|
After #14453 and #14572 static analyzer warnings now look like: Down to 39 warnings - mostly from
|
Just bump the submodule to the desired version. If the tests are passing, binary size doesn't increase and we don't find regressions, we are good to go. |
|
@tmpsantos FYI this landed in #14513 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I hit 112 static analyzer warnings in the CI scheme of ios.xcworkspace on the branch for #7664 (which should be relevant to the release-ios-v3.4.0 branch as well).
@boundsj @frederoni @friedbunny @incanus, can you look through these warnings and see if any merit our attention before the release? Some of the warnings sound alarming, but they may be false alarms. If they aren’t serious issues, we need to find some way to silence them, because they may obscure serious issues that arise in the future.
112 static analyzer warnings
The text was updated successfully, but these errors were encountered: