This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Don't tie Annotation geometries to Map maxzoom #10791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, geometry generation via GeoJSONVT is now bound to the hardcoded limit of the annotation tile source.
kkaefer
added
annotations
asheemmamoowala
approved these changes
Dec 22, 2017
| options.maxZoom = maxZoom; | ||
| // The annotation source is currently hard coded to maxzoom 16, so we're topping out at z16 | ||
| // here as well. | ||
| options.maxZoom = 16; |
There was a problem hiding this comment.
nit: could this be a shared constant with RenderAnnotationSource?
jfirebaugh
approved these changes
Dec 29, 2017
brunoabinader
approved these changes
Jan 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, geometry generation via GeoJSONVT is now bound to the hardcoded limit of the annotation tile source
mapbox-gl-native/src/mbgl/annotation/render_annotation_source.cpp
Lines 41 to 43 in 28a21f3
Fixes #10177