This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
bounds can go over the antimeridian / date line. #10892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osana
force-pushed
the
osana-latlngbounds-10843
branch
from
9ae50e3 to
5e801cf
Compare
tobrun
approved these changes
Jan 11, 2018
osana
force-pushed
the
osana-latlngbounds-10843
branch
from
5e801cf to
a417835
Compare
|
I updated the PR to have LatLngBounds.fromLatLngs() take into consideration that the shortest span could be going over the antimeridian. Added a bunch of tests as well. There is still work left in regards to #10892 as union() and intersects() are not taking antimeridian case into account. |
osana
force-pushed
the
osana-latlngbounds-10843
branch
4 times, most recently
from
d9ca3e6 to
805a23a
Compare
|
@osana what is the state of this PR? is the work around union() and intersects() finalised? |
osana
force-pushed
the
osana-latlngbounds-10843
branch
from
805a23a to
d3ff517
Compare
|
closes #10843 |
|
@tobrun union and intersects still need to be updated |
|
#11308 takes care of union() implementation that takes date line into account |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LatLngBounds did not have an option to specify going over date line bounds.
Stilll need to fix Builder.build() method which should calculate shortest span as new pointe is considered.