Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix style parsing crash when a layer's paint property is not an object #11001

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

kkaefer
Copy link
Contributor

@kkaefer kkaefer commented Jan 23, 2018

Fixes crash reported in #10226.

@kkaefer kkaefer added crash Core The cross-platform C++ core, aka mbgl needs backport Indicates PR needs to be cherrypicked into a previous release branch. labels Jan 23, 2018
Copy link
Contributor

@anandthakker anandthakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm curious as to what non-array value was ending up for paint:

@kkaefer
Copy link
Contributor Author

kkaefer commented Jan 23, 2018

Not sure, I assume the crash report was from a custom non-Mapbox style. In any case, we shouldn't crash on invalid values.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl crash needs backport Indicates PR needs to be cherrypicked into a previous release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants