This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
ui blocking #1112
Merged
ui blocking #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…call misplacement.
…into a serial background thread.
…at are dispatched asynchronously.
|
Looking awesome at first glance. Will try in a bit. |
|
Perf looks great here and I think the approach is sound. I'm not sure how much you've probed multiple map instances running per app, but at the very least it's good practice to unique ID any created queues. I put the app bundle ID into the name for debugging purposes, as well as a globally unique ID just in case. When tests pass I am 👍 to merge. |
incanus
added
the
performance
incanus
added a commit
that referenced
this pull request
Mar 26, 2015
avoid bogging down UI thread with metrics
|
Fantastic! Glad it looks and runs great. Thanks for the crash course on "GCD For Fun And Profit" last night. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draino for #1109