This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Update layer immediately when changing its max/min zoom level #11399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
added
Android
jfirebaugh
reviewed
Mar 10, 2018
There was a problem hiding this comment.
Thanks for taking this on @LukasPaczos! Changes look good. It would be nice to have tests that verify this behavior. There are a few prerequisites to be able to do that though. How do you feel about learning:
- How to extend the node bindings so that they can exercise
setMin/MaxZoom - How to add tests to our render test suite
I or someone else from the GL team would be happy to help walk you through these.
|
Sounds great @jfirebaugh! Please let me know whenever you or anybody else has a moment to hit those bullet points with me. |
ivovandongen
suggested changes
Mar 27, 2018
| return Nan::ThrowTypeError("Second and third arguments must be numbers"); | ||
| } | ||
|
|
||
| mbgl::style::Layer* layer = nodeMap->map->getStyle().getLayer(*Nan::Utf8String(info[0])); |
There was a problem hiding this comment.
You might want to check if the layer actually exists here.
platform/node/src/node_map.cpp
Outdated
|
|
||
| void NodeMap::SetLayerZoomRange(const Nan::FunctionCallbackInfo<v8::Value>& info) { | ||
| using namespace mbgl::style; | ||
| using namespace mbgl::style::conversion; |
There was a problem hiding this comment.
Don't think you need the conversion namespace here right?
LukasPaczos
force-pushed
the
11386-update-layer-with-zoom-change
branch
from
0404f2d
to
b9bffc2
Compare
ivovandongen
approved these changes
Apr 12, 2018
LukasPaczos
added a commit
that referenced
this pull request
Apr 16, 2018
* [android][core] update layer immediately when changing it's max/min zoom * [core] node bindings for layer zoom range (cherry picked from commit 22b4ef1)
This was referenced Apr 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11386.