This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Fix pinch drift ignoring delegate camera change response #11423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
commented
Mar 8, 2018
| @@ -1459,10 +1459,12 @@ - (void)handlePinchGesture:(UIPinchGestureRecognizer *)pinch | |||
| double zoom = log2(newScale); | |||
| MGLMapCamera *toCamera = [self cameraByZoomingToZoomLevel:zoom aroundAnchorPoint:centerPoint]; | |||
|
|
|||
| if ([self _shouldChangeFromCamera:oldCamera toCamera:toCamera]) | |||
| if ( ! [self _shouldChangeFromCamera:oldCamera toCamera:toCamera]) | |||
There was a problem hiding this comment.
This is (obviously) the key line — if the response from the delegate is NO we shouldn’t drift. Previously, this would always allow drifting because, if the delegate responded NO it would move on to the following else.
friedbunny
force-pushed
the
fb-fix-camera-limit-pinch-drift
branch
from
944e6f8 to
e690e7c
Compare
fabian-guerra
approved these changes
Mar 12, 2018
This was referenced Mar 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11422, where the pinch gesture could drift beyond the bounds imposed by
-[MGLMapViewDelegate mapView:shouldChangeFromCamera:toCamera:].This doesn’t add a unit test, but does add a debug option to iosapp.
/cc @julianrex @fabian-guerra @lilykaiser