Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Remove more deprecated bits for release-boba #11681

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

friedbunny
Copy link
Contributor

Follows up on #11205 and removes a couple stragglers that are deprecated as of v3.7.6.

  • Converts a warning to an exception (MGLUserLocationAnnotationTypeException), as promised.
  • Rewords the style class unavailability message.
  • Removes the styleID, bundledStyleURLs, and metersPerPixelAtLatitude: implementations.

/cc @1ec5 @jmkiley

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS refactor SEMVER-MAJOR Requires a major release according to Semantic Versioning rules labels Apr 13, 2018
@friedbunny friedbunny added this to the ios-v4.0.0 milestone Apr 13, 2018
@friedbunny friedbunny self-assigned this Apr 13, 2018
@friedbunny friedbunny requested review from 1ec5 and jmkiley April 13, 2018 21:06
@friedbunny friedbunny changed the title [ios, macos] Remove more deprecated bits for release-boba [ios] Remove more deprecated bits for release-boba Apr 13, 2018
{
[NSException raise:@"Method unavailable" format:
@"%s has been replaced by -[MGLMapView setStyleURL:].\n\n"
@"If you previously set this style ID in a storyboard inspectable, select the MGLMapView in Interface Builder and delete the “styleID” entry from the User Defined Runtime Attributes section of the Identity inspector. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would pretty confusing to get a more generic exception when upgrading from v2.x to v4.0.0, but hopefully that’s a minuscule number of developers. 😉

@friedbunny friedbunny merged commit 0529c01 into release-boba Apr 16, 2018
@friedbunny friedbunny deleted the fb-more-boba-deprecation-removals branch April 16, 2018 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS refactor SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants