This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Use center property (instead of frame) when repositioning annotation views #11817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
added
bug
iOS
fabian-guerra
approved these changes
May 2, 2018
platform/ios/CHANGELOG.md
Outdated
|
|
||
| ### Annotations | ||
| * Fixed an issue where selecting an onscreen annotation could move the map unintentionally. ([#11731](https://github.com/mapbox/mapbox-gl-native/pull/11731)) | ||
| * Fixed an issue where annotation views could become distorted if `rotatesToMatchCamera` is `YES`. ([#11756](https://github.com/mapbox/mapbox-gl-native/issues/11756)) |
There was a problem hiding this comment.
Shouldn't this blurb refer to ([#11817](https://github.com/mapbox/mapbox-gl-native/pull/11817)) instead?
There was a problem hiding this comment.
Good question - do we normally refer to the source ticket or the PR in the change log?
There was a problem hiding this comment.
We always refer to the PR that fixed the issue.
|
@julianrex awesome, this definitely does fix the issue. In manual testing I don’t see any evidence of the side-effects I was worried might exist, but it would be good to add a regression test for #11756. |
… annotation views (when adding back into queue).
julianrex
force-pushed
the
jrex-11756-distorted-annotation-view
branch
from
59d89d6 to
13985d5
Compare
|
That's why I added that flag to that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #11756.