Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix crash when trying to parse legacy filters #12263

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

kkaefer
Copy link
Member

@kkaefer kkaefer commented Jun 29, 2018

Legacy filters aren't part of the style specification, but you can generate them by parsing a legacy filter in a stylesheet, and obtaining the parsed Filter and serializing it.

Legacy filters aren't part of the style specification, but you can generate them by parsing a legacy filter in a stylesheet, and obtaining the parsed Filter and serializing it.
@kkaefer
Copy link
Member Author

kkaefer commented Jun 29, 2018

Before this fix, expressions that start with filter- are considered feature-constant, even though they aren't.

@anandthakker
Copy link
Contributor

Follow up #12264

@kkaefer kkaefer merged commit ca5b36b into master Jun 29, 2018
@kkaefer kkaefer deleted the parse-legacy-filters branch June 29, 2018 19:14
@friedbunny friedbunny added crash Core The cross-platform C++ core, aka mbgl needs changelog Indicates PR needs a changelog entry prior to merging. labels Jul 5, 2018
@friedbunny friedbunny removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl crash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants