This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove 'preinstall' #12464
Merged
Remove 'preinstall' #12464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an obsolete workaround for old npm versions that broke with bundling but also did not install deps predictably. Refs: - https://github.com/mapbox/node-pre-gyp/blob/master/README.md#configuring - mapbox/node-pre-gyp#260
jfirebaugh
approved these changes
Jul 23, 2018
|
Thanks @springmeyer! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
"preinstall": "npm install node-pre-gyp",. This is not needed and also might cause problems with somenpmversions. So it should be removed.I was originally added as part of moving away from putting
node-pre-gypin thebundledDependencies. But neither of these workarounds are needed with recent node > 4.Refs mapbox/node-pre-gyp#260 (comment)