This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Renderer state #13123
Merged
Renderer state #13123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpsantos
reviewed
Oct 17, 2018
kkaefer
previously requested changes
Oct 17, 2018
There was a problem hiding this comment.
You're changing the unit of the CameraOptions::angle from radians to degrees, but the comment didn't change:
mapbox-gl-native/include/mbgl/map/camera.hpp
Lines 30 to 32 in 7bf29bb
tobrun
reviewed
Oct 17, 2018
brunoabinader
force-pushed
the
renderer-state
branch
from
3d68be8 to
e9373ef
Compare
brunoabinader
force-pushed
the
renderer-state
branch
from
e9373ef to
efac5b3
Compare
tmpsantos
approved these changes
Oct 18, 2018
1ec5
reviewed
Oct 26, 2018
| @@ -1970,7 +1970,7 @@ - (MGLMapCamera *)cameraByRotatingToDirection:(CLLocationDirection)degrees aroun | |||
| MGLMapCamera *camera; | |||
|
|
|||
| mbgl::ScreenCoordinate anchor = mbgl::ScreenCoordinate { anchorPoint.x, anchorPoint.y }; | |||
| currentCameraOptions.angle = degrees * mbgl::util::DEG2RAD; | |||
| currentCameraOptions.angle = degrees; | |||
There was a problem hiding this comment.
This incidentally fixes a missing - that caused -[MGLMapViewDelegate mapView:shouldChangeFromCamera:toCamera:] to get called with an incorrectly rotated “to” camera.
1ec5
reviewed
Oct 26, 2018
Glad this helped @1ec5 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a Memento-like RendererState object that will be responsible for fetching renderer state-related data (being camera positioning the first in the list), while preserving the encapsulation of
mbgl::UpdateParameters.This PR also fixes an inconsistency in our public APIs, in which
mbgl::CameraOptionsshould only accept (and outputs) bearing and pitch values in degrees. We should only use such values in radians internally./cc @kkaefer @tmpsantos @1ec5 @tobrun