This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Change definition of "complete" so offline packs created before #11055 can complete. #14188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2019 11:48
tmpsantos
approved these changes
Mar 21, 2019
Fantastic - thank you! I'll go ahead and merge this one so it can get into the beta, but would love the unit test in for the stable release. |
julianrex
added a commit
that referenced
this pull request
Mar 21, 2019
julianrex
added a commit
that referenced
this pull request
Mar 21, 2019
alfwatt
pushed a commit
that referenced
this pull request
Mar 21, 2019
|
@tobrun is a similar change required on Android? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that causes offline packs created prior to #11055 to be marked as
MGLOfflinePackStateInactiveon iOS/macOS./cc @tobrun