Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Enable/disable presentsWithTransaction when moving to/from a window #14264

Closed
wants to merge 5 commits into from
Closed

[ios] Enable/disable presentsWithTransaction when moving to/from a window #14264

wants to merge 5 commits into from

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented Mar 29, 2019 •
edited
Loading

This is a potential work around for for the slowdown reported in #14232. This may not address the associated crash.

As @jmkiley notes in that issue the cause appears to be the introduction of CAEAGLLayer.presentsWithTransaction in #12895 to synchronize OpenGL and UIKit views.

/cc @kkaefer

@julianrex julianrex added bug iOS Mapbox Maps SDK for iOS needs changelog Indicates PR needs a changelog entry prior to merging. labels Mar 29, 2019
@julianrex julianrex mentioned this pull request Mar 29, 2019
Closed
@julianrex julianrex marked this pull request as ready for review March 29, 2019 05:54
@julianrex julianrex requested review from a team and jmkiley March 29, 2019 05:54
@julianrex julianrex mentioned this pull request Mar 29, 2019
Merged
6 tasks
@julianrex julianrex added this to the release-liquid milestone Mar 29, 2019
@1ec5 1ec5 mentioned this pull request Apr 1, 2019
Closed
@julianrex julianrex force-pushed the jrex/14232-work-around branch from 24361fe to 8a31df3 Compare April 2, 2019 13:13
@julianrex julianrex requested a review from kkaefer April 2, 2019 13:54
@julianrex
Copy link
Contributor Author

@kkaefer I added a change, where the GLKView is recreated in an "emergency" - what else needs to happen here from a core point of view?

@julianrex
Copy link
Contributor Author

Quick note: the emergencyRecreateGL method does not tear down the EAGLContext - with the fear that existing GL resources would still be associated with it, and could be left dangling.

@julianrex julianrex mentioned this pull request Apr 2, 2019
Merged
@julianrex
Copy link
Contributor Author

Closed in preference of #14307

@julianrex julianrex closed this Apr 2, 2019
@friedbunny friedbunny removed needs changelog Indicates PR needs a changelog entry prior to merging. labels Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmkiley jmkiley Awaiting requested review from jmkiley

@kkaefer kkaefer Awaiting requested review from kkaefer

Assignees
No one assigned
Labels
bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
release-liquid
Development

Successfully merging this pull request may close these issues.
2 participants
@julianrex @friedbunny