Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Fix flickering on style change #15127

Merged
merged 4 commits into from
Jul 22, 2019

Conversation

pozdnyakov
Copy link
Contributor

Before:
before

After:
after

Before this change, render sources were invalidating their tiles on each style update, when the new tile set was not yet available (tile set for a source is fetched in a separate request) and it caused flickering. Now updates without available tilesets are ignored.

The flickering was introduced with 88c0914 , it is now partially reverted for the Continuous map mode.
For other map modes, tiles are still cleaned preventing from render tests being flaky, which was the issue fixed by 88c0914

@pozdnyakov pozdnyakov added bug Core The cross-platform C++ core, aka mbgl labels Jul 16, 2019
@pozdnyakov pozdnyakov self-assigned this Jul 16, 2019
@julianrex julianrex added this to the release-q milestone Jul 16, 2019
@pozdnyakov pozdnyakov force-pushed the mikhail_fix_flickering_on_style_change branch from 9ce71c2 to 48397e0 Compare July 17, 2019 10:03
@friedbunny friedbunny added the needs changelog Indicates PR needs a changelog entry prior to merging. label Jul 18, 2019
@pozdnyakov pozdnyakov requested a review from a team July 19, 2019 11:00
…s ready

In Continuous map mode, keep the existing tiles if the new tileset is not
yet available, thus providing smart style transitions without flickering.
Encapsulates the tiles update logic based on the given tile set.
@pozdnyakov pozdnyakov force-pushed the mikhail_fix_flickering_on_style_change branch from 44578d2 to f4fd3a6 Compare July 19, 2019 12:35
@pozdnyakov pozdnyakov merged commit fd8891c into master Jul 22, 2019
@pozdnyakov pozdnyakov deleted the mikhail_fix_flickering_on_style_change branch July 22, 2019 07:41
@chloekraw chloekraw removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants