-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Bump gestures library to v0.5.0, refine thresholds and velocity animations #15136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated changes on my end and looks good. To make CI pass you need to update sub modules and rerun license generation. Would be great if someone else from @mapbox/maps-android could test these changes (or anyone outside of Mapbox).
Installed the test app on this branch and can confirm that changes look good. Map doesn't errantly rotate when trying to tilt the map. |
@chloekraw would you also be able to do some testing on your end? @langsmith should be able to set you up with some test devices/apps. |
@tobrun yep, would be happy to! @langsmith I'll find you tomorrow afternoon. |
I've given @chloekraw a Pixel 2. Installed this branch's version of the Maps SDK test app on it. Also put the |
I tested this PR on a Pixel 3 and also asked my friend who is an Android user to test. I am normally an iPhone user.
Overall, we found the map with this PR to be much better! Great work @LukasPaczos.
@LukasPaczos if any small/easy adjustments come to mind that can address any of this feedback, it could be worth adding into this PR, but I'd be perfectly happy merging as is and cutting new tickets for each piece of feedback. cc @mapbox/maps-android cc @mapbox/maps-ios in case this is also helpful as we're thinking about gestures improvements |
26db139
to
41e966d
Compare
41e966d
to
9fd4d4e
Compare
@chloekraw thank you very much for the amazing feedback!
9fd4d4e adds an additional threshold that makes this experience a bit better.
I'm not exactly sure how to replicate that.
This will be targeted as part of https://github.com/mapbox/mapbox-gl-native/issues/15110. Thanks again everyone for the feedback! |
Closes #14776. Closes #14775.
v0.5.0
, which includes our custom scale gestures detector, dropping the dependency on the compat one and bringing minor improvements, see Accessing hidden field violation - ScaleGestureDetector mapbox-gestures-android#39 and Introduce a custom scale gesture detector implementation mapbox-gestures-android#73.UiSettings
.[last gesture delta change] / [velocityXY]
ratio.I've paid special attention to interactions that occur when the device is used with one hand only, with fingers placed sideways (a tribute to users with long nails 💅) or when the user has to reach to the device that is further away. Those scenarios should be dramatically improved in comparison to the behavior on
master
, even when a phone-on-the-table developer scenario should remain the same or might even require more willingness to register gestures like a rotation with high velocity.I'd love any additional 👀 and feedback from @mapbox/android or anyone able to quickly build the Maps SDK. Most of the magic numbers in the PR have been meticulously chosen to offer the best experience on the devices I could test on locally.
Currently, the PR is built against the gesture's library snapshot. When the feedback is addressed and the PR is approved, I'm going to release the stable
v0.5.0
in order to avoid patch releases if anything comes up that would need to be adjusted on the gesture library's end.I didn't include any additional tests as most of the proposed changes are subjective and we don't have a mechanism to test them.