This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix icon-text-fit #15634
Merged
Fix icon-text-fit #15634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
force-pushed
the
fix-icon-text-fit
branch
from
cc29bd5
to
a5b20e1
Compare
kkaefer
force-pushed
the
fix-icon-text-fit
branch
from
a5b20e1
to
f9cd979
Compare
kkaefer
force-pushed
the
fix-icon-text-fit
branch
from
f9cd979
to
6272510
Compare
kkaefer
force-pushed
the
fix-icon-text-fit
branch
2 times, most recently
from
cf6735c
to
9b4e547
Compare
|
Includes a patch that allows updating the submodule to a more recent version of mapbox-gl-js until we have #15800 implemented. |
This fixes rendering by account for the 1px texture padding around icons that were stretched with icon-text-fit. We've added the 1px padding before, but didn't scale it accordingly when we are resizing the icon when it is stretched to fit the text. Adjusts the code to match the logic in GL JS.
kkaefer
force-pushed
the
fix-icon-text-fit
branch
from
9b4e547
to
afedfcc
Compare
alexshalamov
approved these changes
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes rendering by account for the 1px texture padding around icons that were stretched with icon-text-fit. We've added the 1px padding before, but didn't scale it accordingly when we are resizing the icon when it is stretched to fit the text. Adjusts the code to match the logic in GL JS.
Ports mapbox/mapbox-gl-js#8741 to native.