Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Fix layout of Scale bar components #15703

Merged
merged 13 commits into from
Oct 4, 2019
Merged

[ios] Fix layout of Scale bar components #15703

merged 13 commits into from
Oct 4, 2019

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented Sep 24, 2019 •
edited
Loading

Fixes #15356 and layout when the device is rotated.

EDIT: The PR as it stands also rounds the corners of the scale bar - let me know what you think

Before:
Screen Shot 2019-10-02 at 3 24 11 PM

After:
Screen Shot 2019-10-02 at 3 25 56 PM

@julianrex julianrex changed the title [ios] Scale bar updates [ios] Fix layout of Scale bar components Sep 24, 2019
@julianrex julianrex self-assigned this Sep 24, 2019
@julianrex julianrex added the iOS Mapbox Maps SDK for iOS label Sep 24, 2019
@julianrex julianrex added this to the release-sangria milestone Sep 24, 2019
@julianrex julianrex marked this pull request as ready for review September 24, 2019 12:45
@julianrex julianrex requested review from a team and removed request for a team September 24, 2019 12:45
@julianrex julianrex added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Sep 24, 2019
@julianrex
Copy link
Contributor Author

julianrex commented Sep 24, 2019 •
edited
Loading

A couple of integration tests are failing...
EDIT: Addressed in 9d35945

@julianrex julianrex removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Sep 24, 2019
@julianrex
Copy link
Contributor Author

Rebased to kick CI bots.

@julianrex
Copy link
Contributor Author

julianrex commented Sep 25, 2019 via email •
edited
Loading

@julianrex julianrex mentioned this pull request Sep 30, 2019
Closed
fabian-guerra
fabian-guerra reviewed Oct 2, 2019
View reviewed changes
Copy link
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. Could you please add an screenshot of what do you mean with:

EDIT: The PR as it stands also rounds the corners of the scale bar - let me know what you think.

platform/ios/CHANGELOG.md Outdated Show resolved Hide resolved
Julian Rex added 11 commits October 3, 2019 23:11
@julianrex
Copy link
Contributor Author

@fabian-guerra addressed your feedback, ready for another look.

fabian-guerra
fabian-guerra approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I like how the scale bar looks.

@julianrex julianrex merged commit cab7563 into master Oct 4, 2019
@julianrex julianrex deleted the jrex/15356-scalebar-2 branch October 4, 2019 15:15
@julianrex
Copy link
Contributor Author

julianrex commented Oct 4, 2019 •
edited
Loading

Merging so we can test in the next alpha/beta. We may want to revert the rounded corners if performance is affected badly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabian-guerra fabian-guerra fabian-guerra approved these changes

@friedbunny friedbunny Awaiting requested review from friedbunny

@jmkiley jmkiley Awaiting requested review from jmkiley

Assignees

@julianrex julianrex

Labels
iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
release-sangria
Development

Successfully merging this pull request may close these issues.

[iOS] Bars in scalebar have different sizes
2 participants
@julianrex @fabian-guerra