Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Expose pre-fetching zoom delta. #15769

Merged
merged 8 commits into from
Oct 8, 2019
Merged

[android] Expose pre-fetching zoom delta. #15769

merged 8 commits into from
Oct 8, 2019

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Oct 7, 2019 •
edited
Loading

Expose getPrefetchZoomDelta() and setPrefetchZoomDelta(int) methods to the MapboxMap.

Deprecated setPrefetchesTiles(boolean) and getPrefetchTiles to migrate to setPrefetchZoomDelta(int) and setPrefetchZoomDelta.

@pengdev pengdev added the Android Mapbox Maps SDK for Android label Oct 7, 2019
@pengdev pengdev requested a review from a team October 7, 2019 12:47
@pengdev pengdev self-assigned this Oct 7, 2019
@pengdev pengdev added the needs changelog Indicates PR needs a changelog entry prior to merging. label Oct 7, 2019
LukasPaczos
LukasPaczos approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise 🚢

platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxMap.java Show resolved Hide resolved
tobrun
tobrun reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add one more test to NativeMapViewTest.kt? This verifies that the new API works at runtime though instrumented tests on firebase

...orm/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxMapOptions.java Show resolved Hide resolved
@pengdev
Copy link
Member Author

pengdev commented Oct 8, 2019

Could you add one more test to NativeMapViewTest.kt? This verifies that the new API works at runtime though instrumented tests on firebase

Good catch, sorry I missed that, added now.

@pengdev pengdev merged commit 7139abd into master Oct 8, 2019
@pengdev pengdev deleted the peng-expose-prefetch-zoom-delta branch October 8, 2019 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees

@pengdev pengdev

Labels
Android Mapbox Maps SDK for Android needs changelog Indicates PR needs a changelog entry prior to merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pengdev @tobrun @LukasPaczos