This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Avoid GeoJSON source flickering on style transitions #15907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, all GeoJSON source cleared tile pyramid at the style transition and it caused flickering. Now, in Continuous mode, we keep the existing tiles until the new GeoJSON data is not yet available, thus providing smart style transitions without flickering. In other modes (Static, Tile) clear the tile pyramid in order to avoid render tests being flaky.
pozdnyakov
added
bug
Core
pozdnyakov
removed
the
needs changelog
Done, thanks! |
alexshalamov
approved these changes
Nov 12, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the GeoJSON source cleared tile pyramid
at any style transition and it caused flickering.
Now, in Continuous mode, we keep the existing tiles until the
new GeoJSON data is available, thus providing smart
style transitions without flickering.
In other modes (Static, Tile) clear the tile pyramid in order
to avoid render tests being flaky.
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/104