This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Don't use signed int type for anchor segment #16008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
force-pushed
the
alexshalamov_signed_to_unsigned_conversion
branch
from
53e3052
to
bed453e
Compare
pozdnyakov
reviewed
Dec 5, 2019
alexshalamov
force-pushed
the
alexshalamov_signed_to_unsigned_conversion
branch
from
bed453e
to
c2899f7
Compare
springmeyer
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Confirmed that this resolved the UBSAN "runtime error" in downstream testing against c2899f7. Thanks @alexshalamov!
pozdnyakov
approved these changes
Dec 9, 2019
alexshalamov
force-pushed
the
alexshalamov_signed_to_unsigned_conversion
branch
from
d715cf2
to
6e79d71
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erroneous signed to unsigned implicit conversion was used when PlacedSymbol(s) were created in SymbolLayout and signed values were used as indexes in a few other places.