-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
dce72a8
to
9bd67c0
Compare
Remaining questions:
|
9bd67c0
to
b889536
Compare
2622cb0
to
23a78d7
Compare
Yep, should we do something to enable some fractional values? I could see half pixel values being useful but not sure about anything beyond that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! few nits
I took a look a look at the core logic part and I checked that all the followup fixes I made in -js are also included here. Those look good (assuming the TODOs are done). I'll leave the rest of the review to Alex |
23a78d7
to
af2ec74
Compare
f9a7817
to
d7b4073
Compare
@alexshalamov thanks for rebaselining! We're using a lot of |
d7b4073
to
394809f
Compare
…ct to mirror the JS implementation
94d6b8d
to
4a4a197
Compare
4a4a197
to
3fce98b
Compare
Fixes #16017
Implements stretchable icons, porting from JS.